> -----Original Message----- > From: Jakub Kicinski <kuba@xxxxxxxxxx> > Sent: Thursday, October 5, 2023 2:11 AM > To: Pandey, Radhey Shyam <radhey.shyam.pandey@xxxxxxx> > Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx; > robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>; > linux@xxxxxxxxxxxxxxx; f.fainelli@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>; Sarath Babu > Naidu Gaddam <sarath.babu.naidu.gaddam@xxxxxxx> > Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for > dmaengine support > > On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote: > > */ > > -static int axienet_open(struct net_device *ndev) > > + > > nit: spurious new line > > > +static inline int axienet_init_legacy_dma(struct net_device *ndev) > > nit: no need for the inline, it has one caller and isn't on the fast path Thanks, will fix both in next version.
