On Wed, Sep 27, 2023 at 02:21:18PM +0530, Saravanan Sekar wrote: > On 27/09/23 13:36, Krzysztof Kozlowski wrote: > > On 27/09/2023 05:39, Saravanan Sekar wrote: > > > Document mpq2286 power-management IC > > > > > > Signed-off-by: Saravanan Sekar <saravanan@xxxxxxxxxxx> > > > --- > > > .../bindings/regulator/mps,mpq2286.yaml | 59 +++++++++++++++++++ > > > 1 file changed, 59 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml > > > new file mode 100644 > > > index 000000000000..594b929fe4b8 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml > > > @@ -0,0 +1,59 @@ > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/regulator/mps,mpq2286.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Monolithic Power System MPQ2286 PMIC > > > + > > > +maintainers: > > > + - Saravanan Sekar <saravanan@xxxxxxxxxxx> > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - mps,mpq2286 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + regulators: > > > + type: object > > > + > > > + properties: > > > + buck0: > > > > If you have just one buck, it should be "buck". > > > > As replied in v1 review comments, other chipset has multiple regulator so > buck0 used to keep the driver common This patch needs to stand on its own with explanations/justifications. No one reviewing this remembers what was said in some reply. The explanation may be in the commit msg, under the '---', or in 'description' here. Depends on the situation. I don't see why the driver can't handle 'buck' and 'buckN'. Rob
