Hello Bjorn, > From: Bjorn Helgaas, Sent: Friday, October 6, 2023 12:09 AM > > On Tue, Sep 26, 2023 at 09:24:28PM +0900, Yoshihiro Shimoda wrote: > > Add R-Car Gen4 PCIe controller support for host mode. > > > > This controller is based on Synopsys DesignWare PCIe. However, this > > particular controller has a number of vendor-specific registers, and as > > such, requires initialization code like mode setting and retraining and > > so on. > > > > [kwilczynski: commit log] > > Link: https://lore.kernel.org/linux-pci/20230825093219.2685912-17-yoshihiro.shimoda.uh@xxxxxxxxxxx/ > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > Signed-off-by: Krzysztof Wilczyński <kwilczynski@xxxxxxxxxx> > > You should never include a signed-off-by from the person you're > sending the patch *to*; this "Signed-off-by: Krzysztof Wilczyński > <kwilczynski@xxxxxxxxxx>" should be added by Krzysztof when he applies > it. I understood it. > Whoever applies this, please s/PCI: dwc:/PCI:/ in this subject and the > "Add endpoint mode support" patch. No need to include *both* "dwc:" > and "rcar-gen4". > > > +config PCIE_RCAR_GEN4_HOST > > + tristate "Renesas R-Car Gen4 PCIe controller (host mode)" > > + depends on ARCH_RENESAS || COMPILE_TEST > > + depends on PCI_MSI > > + select PCIE_DW_HOST > > + select PCIE_RCAR_GEN4 > > + help > > + Say Y here if you want PCIe controller (host mode) on R-Car Gen4 SoCs. > > + To compile this driver as a module, choose M here: the module will be > > + called pcie-rcar-gen4.ko. This uses the DesignWare core. > > This should be sorted so the menuconfig prompts are in alpha order. > > > + * Manually initiate the speed change. Return true if the change succeeded, > > + * false if the change didn't finish within certain periods. > > "Return 0 if change succeeded; otherwise -ETIMEDOUT". > > No need to repost unless somebody suggests more significant rework; > these can be tweaked when merging. I got it. > Thanks a lot for squashing into a single file; that's a major > simplification. I think so. Thank you for your review. Best regards, Yoshihiro Shimoda > Bjorn
