Am Donnerstag, 5. Oktober 2023, 17:39:18 CEST schrieb Benjamin Gaignard: > > Le 05/10/2023 à 17:30, Heiko Stuebner a écrit : > > Am Donnerstag, 5. Oktober 2023, 17:12:10 CEST schrieb Sebastian Reichel: > >> Hi, > >> > >> On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote: > >>> Add node for AV1 video decoder. > >>> > >>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx> > >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > >> No need for my SoB. Instead have this one: > >> > >> Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > >> > >> Also worth mentioning, that this Patch needs one small fix in the DT > >> binding (adding "resets") and one small fix in the driver for out of > >> the box AV1 support: > >> > >> https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@xxxxxxxxxxxxx/ > >> https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@xxxxxxxxxxxxx/ > > additionally the node name should be generic. > > The phandle can of course be av1d but the node > > name itself needs a change. > > Does "video-codec-av1@fdc70000" sound good for you ? Nope ... please go with video-codec@fdc... I.e. see the other Rockchip soc dtsi for reference. Thanks Heiko
