On Thu, 5 Oct 2023 20:14:41 +0800 Rohan G Thomas wrote: > > So the question now is whether we want Rohan to do this conversion _first_, > > in DW QoS 5, and then add xgmac part. Or the patch should go in as is and > > you'll follow up with the conversion? > > If agreed, this commit can go in. I can submit another patch with the > refactoring suggested by Serge. Did you miss the emphasis I put on the word "first" in my reply? Cleanup first, nobody will be keeping track whether your fulfilled your promises or not :|