On 04/10/2023 17:00, Andreas Kemnade wrote:
> On Wed, 4 Oct 2023 16:53:14 +0200
> Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
>
>> Hi,
>>
>> On Wed, 4 Oct 2023 09:59:59 +0200
>> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> [...]
>>>> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
>>>> index 46a80eacf771..6a790124bcf5 100644
>>>> --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
>>>> +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
>>>> @@ -447,10 +447,12 @@ &uart2 {
>>>> interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
>>>> &omap4_pmx_core OMAP4_UART2_RX>;
>>>>
>>>> - /*
>>>> - * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
>>>> - * which does not have a driver
>>>> - */
>>>> + bluetooth-gnss {
>>>
>>> If you changed the bindings, please share a link. If not, this is not
>>> currently accepted and dtbs_check should point it out.
>>>
>>
>> according to dtbs_check:
>>
>> good:
>> - bluetooth-gnss
>> - bluettooth-gnss
>>
>> bad:
>> - bluettooth-gnnss
>> - tiwi (still there in pandaboards)
>>
> The only authoritative source I find here:
> Documentation/devicetree/bindings/serial/serial.yaml:
> patternProperties:
> "^bluetooth|gnss|gps|mcu$":
Yes, it's about this one.
>
> It allows:
> everything starting with bluetooth
> everything containing gnss
> everything containing gps
> everything ending with mcu
>
> bluetooth-gnss starts with bluetooth, so it is allowed.
> Do you have anything else forbidding bluetooth-gnss?
Heh, the pattern is wrong. This should be originally:
"^(bluetooth|gnss|gps|mcu)$":
I can fix it and also allow your use case.
Best regards,
Krzysztof
