On Tue, Oct 03, 2023 at 10:49:10PM +0200, Linus Walleij wrote: > Hi Takahiro, > > On Mon, Oct 2, 2023 at 4:17???AM AKASHI Takahiro > <takahiro.akashi@xxxxxxxxxx> wrote: > > > This allows for enabling SCMI pinctrl based GPIO driver to obtain > > an input gpio pin. > > > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> > (...) > > + * @PIN_CONFIG_INPUT: This will obtain a value on an input pin. The returned > > + * argument indicates the value. > > We need to specify that this is the inverse of @PIN_CONFIG_OUTPUT, > that setting a line into *input mode* requires the use of > @PIN_CONFIG_INPUT_ENABLE, so the config can never be set > but should return an error on set, and that the argument returned is 1 for > logic high and 0 for logic low. I will add more as you suggest. -Takahiro Akashi > Otherwise I think this is fine! > > Yours, > Linus Walleij
