On Mon, Oct 02, 2023 at 04:11:10PM +0300, Vladimir Oltean wrote: > Hi Simon, > > On Thu, Sep 28, 2023 at 09:05:36PM +0200, Simon Horman wrote: > > On Sat, Sep 23, 2023 at 04:48:52PM +0300, Vladimir Oltean wrote: > > > > ... > > > > > +/** > > > + * coef_update_opposite - return the opposite of one C72 coefficient update > > > + * request > > > + * > > > + * @update: original coefficient update > > > + * > > > + * Helper to transform the update request of one equalization tap into a > > > + * request of the same tap in the opposite direction. May be used by C72 > > > + * phy remote TX link training algorithms. > > > + */ > > > +static inline enum coef_update coef_update_opposite(enum coef_update update) > > > > Hi Vladimir, > > > > another nit from me. > > > > Please put the inline keyword first. > > Likewise elsewhere in this patch. > > > > Tooling, including gcc-13 with W=1, complains about this. > > Thanks for pointing this out. I guess you are talking about the c72_coef_update_print() > function, whose prototype is mistakenly "static void inline" instead of > "static inline void". I cannot find the problem with the quoted coef_update_opposite(). Yes, you are right. Sorry for my error.
