On 01/10/2023 20:13, Ayush Singh wrote:
>>>>> +};
>>>>> +MODULE_DEVICE_TABLE(of, gb_beagleplay_of_match);
>>>>> +
>>>>> +static struct serdev_device_driver gb_beagleplay_driver = {
>>>>> + .probe = gb_beagleplay_probe,
>>>>> + .remove = gb_beagleplay_remove,
>>>>> + .driver = {
>>>>> + .name = "gb_beagleplay",
>>>>> + .of_match_table = gb_beagleplay_of_match,
>>>> This is still wrongly aligned. Spaces after tab. Are you sure checkpatch
>>>> does not complain bout it?
>>> Again, it doesn't seem to for me. Am I missing some environment
>>> variables or options? Or maybe something wrong with my editor config
>>> (neovim)?
>> You have spaces after tab, so how can this be properly aligned?
>>
>> Best regards,
>> Krzysztof
>>
> So I just wanted to confirm, but I think spaces after tab are fine for
> alignment, right? I found this
> (https://www.mail-archive.com/kernelnewbies@xxxxxxxxxxxxxxxxx/msg13354.html)
> message in mailing list stating that it is fine.
Spaces after tab are fine *when needed* for proper alignment. You do not
have proper alignment here, so just drop them. Please open any other
existing driver (although not something old...).
Best regards,
Krzysztof
