On Fri, Sep 29, 2023 at 06:02:57PM +0200, Konrad Dybcio wrote:
> The DP PHY needs different settings when an eDP display is used.
> Make sure these apply on the X13s.
Good catch. This looks to be more in line with what Bjorn intended.
You should fix up sc8280xp-crd and sa8295p-adp.dts as well however.
> FWIW
> I could not notice any user-facing change stemming from this commit.
I've seen some infrequent link-training failures (e.g. on resume) even if
it's been a while since last time now.
> Fixes: f48c70b111b4 ("arm64: dts: qcom: sc8280xp-x13s: enable eDP display")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> I have no idea whether DP3 is hardwired to be eDP, like it
> seems to be on the last DP controller of SC7280. In that
> case this would be moved to the SoC DTSI.
sa8295p-adp appears to use mdss[01]_dp[23] for eDP.
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index 38edaf51aa34..6a4c6cc19c09 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -601,6 +601,7 @@ mdss0_dp3_out: endpoint {
> };
>
> &mdss0_dp3_phy {
> + compatible = "qcom,sc8280xp-edp-phy";
Nit: Can you add a newline here after the compatible, please?
> vdda-phy-supply = <&vreg_l6b>;
> vdda-pll-supply = <&vreg_l3b>;
Johan
