On Thu, Sep 28, 2023 at 12:28:04PM +0300, Eliza Balas wrote: > --- /dev/null > +++ b/drivers/misc/adi-axi-tdd.c > @@ -0,0 +1,780 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) License comment, why is this dual licensed? You are calling gpl-only-marked functions in this driver so attempting to say it is also BSD is quite odd, how are you going to resolve that? Has a lawyer agreed with this licensing? Please get a lawyer to sign off on your next contribution of this with a dual license to ensure that they agree and that you all fully understand the legal issues and complexity of attempting to have dual-licensed Linux kernel code (hint, it's not as simple as you might think...) And document in the changelog _why_ you want this to be dual licensed so that we can all review that as well. thanks, greg k-h