On Wed, Sep 27, 2023 at 08:16:29PM +0800, wangweidong.a@xxxxxxxxxx wrote: > From: Weidong Wang <wangweidong.a@xxxxxxxxxx> > > Remove the "fade-enable" property because other properties > already implement this functionality. > Rename "sound-channel" to "awinic,audio-channel", > this is to be consistent with the "awinic,aw88395.yaml" file This feels like it should be split into two patches. patch 4/9: remove the "fade-enable property". Btw, which other properties implement this. Can you add that to the commit message? patch 5/9: Rename "sound-channel" to "awinic,audio-channel". regards, dan carpenter