On 27.09.2023 13:16, Bryan O'Donoghue wrote: > On 27/09/2023 12:05, Konrad Dybcio wrote: >> On 27.09.2023 13:01, Bryan O'Donoghue wrote: >>> On 27/09/2023 10:21, Konrad Dybcio wrote: >>>> To make dtbs_check happy and the software more aware of what's going >>>> on, describe the HSUSB PHY's regulators and tighten up VDDA_PLL to match. >>>> >>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >>>> --- >>>> arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts | 7 +++++-- >>>> 1 file changed, 5 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >>>> index bbec7aee60be..0ce4fa8de8b0 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >>>> +++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >>>> @@ -243,8 +243,8 @@ pm6125_l6: l6 { >>>> }; >>>> pm6125_l7: l7 { >>>> - regulator-min-microvolt = <720000>; >>>> - regulator-max-microvolt = <1050000>; >>>> + regulator-min-microvolt = <880000>; >>>> + regulator-max-microvolt = <880000>; >>> >>> Where did the old values come from and why are the new values better ? >>> >>> Consider enumerating that in the commit log. >> That's the pretty standard situation where: >> >> - downstream defines very loose ranges >> - developer uses these very loose ranges as a guideline >> - some hardware (often the exclusive user of that regulator) >> has a hidden-ish request of a tighter range >> - the developer realizes that and has to fix up the ranges >> >> Konrad > > If you got 72 and 105 from downstream, where did you get 88 from ? Also from downstream, except from the consumer driver Konrad