>From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >Sent: 2023年9月27日 16:11 >To: Ming Qian <ming.qian@xxxxxxx>; Conor Dooley <conor@xxxxxxxxxx> >Cc: Mirela Rabulea (OSS) <mirela.rabulea@xxxxxxxxxxx>; >robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; >krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; >mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; >kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; X.H. Bao ><xiahong.bao@xxxxxxx>; Eagle Zhou <eagle.zhou@xxxxxxx>; Tao Jiang ><tao.jiang_2@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; >devicetree@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >Subject: Re: [EXT] Re: [PATCH v4 2/2] dt-bindings: media: imx-jpeg: Assign slot >for imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On 27/09/2023 04:10, Ming Qian wrote: >>> From: Conor Dooley <conor@xxxxxxxxxx> >>> Sent: 2023年9月26日 21:26 >>> To: Ming Qian <ming.qian@xxxxxxx> >>> Cc: Mirela Rabulea (OSS) <mirela.rabulea@xxxxxxxxxxx>; >>> robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; >>> krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; >>> mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; >>> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; X.H. Bao >>> <xiahong.bao@xxxxxxx>; Eagle Zhou <eagle.zhou@xxxxxxx>; Tao Jiang >>> <tao.jiang_2@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; >>> devicetree@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- >>> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >>> Subject: [EXT] Re: [PATCH v4 2/2] dt-bindings: media: imx-jpeg: >>> Assign slot for imx jpeg encoder/decoder >>> >>> Hi, >>> >>> On Tue, Sep 26, 2023 at 06:10:00PM +0800, Ming Qian wrote: >>>> There are total 4 slots available in the IP, and we only need to use >>>> one slot in one os, assign a single slot, configure interrupt and >>>> power domain only for 1 slot, not for the all 4 slots. >>>> >>>> Signed-off-by: Ming Qian <ming.qian@xxxxxxx> >>>> --- >>>> v4 >>>> - improve commit message >>> >>>> - don't make an ABI break >>> >>> What does this mean? Can you please try to explain things a bit more >>> clearly in your changelogs? >>> >>> Also, where is the code that actually makes use of these properties? >> >> In v3 patch, I make this property required, make it an ABI break, so in v4, I >remove it from required, and default to the previous behavior if it is missing. > >So say that you dropped line making the property required. > Got it, thanks >> >> The code patch is sent before, but the dts change is not applicable, so I send >it separately. The code patch link is as below: >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc >> hwork.linuxtv.org%2Fproject%2Flinux- >media%2Fpatch%2Fcdadb4a23697fdc97d >> >ef958c69b12cd00f547212.1685430841.git.ming.qian%40nxp.com%2F&data=0 >5%7 >> >C01%7Cming.qian%40nxp.com%7C8ea6dd7c90564f331d9108dbbf313eca%7C >686ea1d >> >3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638313990445947012%7CUnkno >wn%7CTWF >> >pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC >I6M >> >n0%3D%7C3000%7C%7C%7C&sdata=Hl6F1Th8FvfoGul5nhnvsf%2FKsXqpjZFhp >r2y3U3C >> hhw%3D&reserved=0 >> >> But in the patch, the property name is "slot", not "nxp,slot", I will make >another patch to fix the property name after this patch is reviewed. > >Format your emails properly. It's difficult to read it. > >I already NAKed it, I will be NAKing still. Don't embed OS specific into the >bindings nor into the DTS. > > >Best regards, >Krzysztof Hi Krzysztof, Do you mean the link is inappropriate or something else? I will avoid links in my emails in the future. I'm sorry to bother you. Best regards, Ming Qian
