On Mon, Sep 25, 2023 at 10:53:12PM +0530, Om Prakash Singh wrote:
> From: Om Prakash Singh <omprsing@xxxxxxxxxxxxxxxx>
That is not a valid email address here, please correct this.
>
> Add hw_random interface support in qcom-rng driver as new IP block
> in Qualcomm SoC has inbuilt NIST SP800 90B compliant entropic source
> to generate true random number.
>
> Keeping current rng_alg interface as well for random number generation
> using Kernel Crypto API.
>
> Signed-off-by: Om Prakash Singh <quic_omprsing@xxxxxxxxxxx>
[..]
> diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
[..]
> +static int qcom_hwrng_read(struct hwrng *hwrng, void *data, size_t max, bool wait)
> +{
> + struct qcom_rng *qrng = container_of(hwrng, struct qcom_rng, hwrng);
Please also remove one of the spaces after '='.
Other than that, this looks good to me.
Regards,
Bjorn
