On 23/08/2023 09:48, Daniel Lezcano wrote:
On 31/05/2023 10:05, AngeloGioacchino Del Regno wrote:
[ ... ]
static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = {
{
.cal_offset = { 0x04, 0x07 },
@@ -1268,6 +1300,8 @@ MODULE_DEVICE_TABLE(of, lvts_of_match);
static struct platform_driver lvts_driver = {
.probe = lvts_probe,
.remove = lvts_remove,
+ .suspend = lvts_suspend,
Should we do that in noirq handlers?
We're risking to miss a thermal interrupt.
I'm not sure missing a thermal interrupt is a problem in this context
but we may go in the irq routine with an undefined state sensor setup
(eg. the internal clock stopped in the suspend and then read the sensor
in the isr).
IMO, using suspend_noirq and resume_noirq may be required here.
Alexandre are you taking over the next iteration?
Hi Daniel,
Sorry I missed your message...
I don't think taking over the next iteration, Bernhard should continue.
Let me check internally to be sure. As I understood, the next change
should be heavy.
--
Regards,
Alexandre
