On 2023/9/25 18:58, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 25/09/2023 12:45, Krzysztof Kozlowski wrote: >> On 25/09/2023 12:42, Huqiang Qin wrote: >>> Hi Krzysztof, >>> >>> On 2023/9/25 17:33, Krzysztof Kozlowski wrote: >>>> This is c3, not t7. Why do you use t7 compatible alone? >>> >>> The C3 and T7 use the same watchdog controller, so they are compatible. >> >> I am not saying that they are not compatible. I am saying that different >> SoCs should use the same compatible. Just like for every other platform, > > Eh, missing "not", so "should not use": > > I am not saying that they are not compatible. I am saying that different > SoCs should not use the same compatible. Just like for every other > platform, Amlogic is not special here. > >> Amlogic is not special here. >> >> https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst > > Please define compatibility list with t7 as fallback. Okay, got it, I will modify it in the next version. Thanks Best regards, Huqiang Qin