>From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >Sent: 2023年9月25日 16:02 >To: Ming Qian <ming.qian@xxxxxxx>; Mirela Rabulea (OSS) ><mirela.rabulea@xxxxxxxxxxx>; robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx >Cc: krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; >mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; >kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; X.H. Bao ><xiahong.bao@xxxxxxx>; Eagle Zhou <eagle.zhou@xxxxxxx>; Tao Jiang ><tao.jiang_2@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; >devicetree@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot for >imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On 25/09/2023 09:41, Ming Qian wrote: >> There are total 4 slots available in the IP, and we only need to use >> one slot in one os, assign a single slot, configure interrupt and >> power domain only for 1 slot, not for the all 4 slots. > >No changelog and I do not see much of improvements. Do not ignore the >feedback but respond to it or fix the patch. Really, what happened here? > Hi Krzysztof, What do you mean wrap commit message? Do you mean line wrapped at 75 columns? - The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch. >Please wrap commit message according to Linux coding style / submission >process (neither too early nor over the limit): >https://elixir.b/ >ootlin.com%2Flinux%2Fv6.4- >rc1%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting- >patches.rst%23L597&data=05%7C01%7Cming.qian%40nxp.com%7C9a78ca292 >a5744790db208dbbd9da8e3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% >7C0%7C638312257061769802%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w >LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C% >7C%7C&sdata=gDnMim2nrLIQflmmGu6cahz0prZV9iKslevv208u06U%3D&reser >ved=0 > >> >> Signed-off-by: Ming Qian <ming.qian@xxxxxxx> >> --- >> .../bindings/media/nxp,imx8-jpeg.yaml | 42 ++++++++----------- >> 1 file changed, 18 insertions(+), 24 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> index 3d9d1db37040..df381b21336d 100644 >> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> @@ -32,25 +32,29 @@ properties: >> maxItems: 1 >> >> interrupts: >> - description: | >> - There are 4 slots available in the IP, which the driver may use >> - If a certain slot is used, it should have an associated interrupt >> - The interrupt with index i is assumed to be for slot i >> - minItems: 1 # At least one slot is needed by the driver >> - maxItems: 4 # The IP has 4 slots available for use >> + description: >> + Interrupt number for slot >> + maxItems: 1 >> >> power-domains: >> description: >> List of phandle and PM domain specifier as documented in >> Documentation/devicetree/bindings/power/power_domain.txt >> - minItems: 2 # Wrapper and 1 slot >> - maxItems: 5 # Wrapper and 4 slots >> + minItems: 1 # VPUMIX >> + maxItems: 2 # Wrapper and 1 slot >> + >> + nxp,slot: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Integer number of slot index used. >> + minimum: 0 >> + maximum: 3 > >Nothing explains what is a slot and nothing explains why do you need this >property. > >> >> required: >> - compatible >> - reg >> - interrupts >> - power-domains >> + - nxp,slot > >NAK, that's an ABI break. > >Best regards, >Krzysztof