Hi Krzysztof,
Thanks for the reviews.
On Sat, 2023-09-23 at 20:08 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 18/09/2023 21:22, Jason-JH.Lin wrote:
> > Add mt8195 support for CMDQ secure driver.
>
> How is it anyhow related to your patch content?
This path is dependent on cmdq_probe() in [PATCH 9/15].
>
> >
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
> > ---
> > drivers/mailbox/mtk-cmdq-mailbox.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c
> b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index 4e047dc916b9..d27d033c587d 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -735,6 +735,7 @@ static const struct gce_plat gce_plat_v6 = {
> > .thread_nr = 24,
> > .shift = 3,
> > .control_by_sw = true,
> > +.has_sec = true,
>
> Really, how?
Within this flag, cmdq_probe() will call
platform_device_register_data() to setup a CMDQ secure driver.
Regards,
Jason-JH.Lin
>
> Best regards,
> Krzysztof
>
>
