On Thu, 21 Sep 2023 09:43:45 -0500 David Lechner <dlechner@xxxxxxxxxxxx> wrote: > In theory, this code path should not be reachable because of the > previous switch statement. But just in case we should make sure we > are restoring the SAMPLE gpio to its original state before returning > in addition to releasing the mutex lock. > > Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx> Applied to the togreg branch of iio.git and pushed out as testing for all the normal reasons. Thanks, Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > index 84743e31261a..0bdd5a30d45d 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -510,8 +510,8 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, > ret = IIO_VAL_INT; > break; > default: > - mutex_unlock(&st->lock); > - return -EINVAL; > + ret = -EINVAL; > + break; > } > > error_ret:
