On Sun, Sep 24, 2023 at 10:49:49AM +0300, Arınç ÜNAL wrote: > On 24/09/2023 06:15, Andrew Lunn wrote: > > > > There is a MAC driver currently under review which does not have a PHY > > > > at all. The MAC is directly connected to a switch, all within one > > > > IC. The link is always running at 5Gbps, the link is always up. It is > > > > physically impossible to connect a PHY, so get_link_settings just > > > > returns hard coded values. > > > > > > The fixed-link property would be used to describe the link of the MAC here. > > > > Fixed-link make sense for a general purpose MAC which could be > > connected to a PHY, or could also be used without a PHY. fixed-link > > simplifies the code in that the MAC driver does not see a difference, > > it all looks like a PHY. > > > > However for a MAC which cannot be connected to a PHY, there is no need > > to emulate a PHY. The MAC driver will be simpler. So i would not > > recommend a fixed-link in this situation. > > There's a link, it must be described. Why must it be described? Lets take this to the extreme to make a point. The chip has a ground pin. Must i describe that? Andrew