On 24/09/2023 13:36, Ayush Singh wrote: > Adds DT bindings for BeaglePlay CC1352 co-processor. I gave you the link to the exact wording you should use. "Add", not "Adds". The latter is not a correct English sentences, I believe. > > BeaglePlay has a CC1352 co-processor connected to the main AM62 (running > Linux) over UART. In the BeagleConnect Technology, CC1352 is responsible > for handling 6LoWPAN communication with beagleconnect freedom nodes as > well as their discovery. > > It is used by gb-beagleplay greybus driver. > > Signed-off-by: Ayush Singh <ayushdevel1325@xxxxxxxxx> > --- > .../bindings/net/beagle,play-cc1352.yaml | 25 +++++++++++++++++++ > MAINTAINERS | 6 +++++ > 2 files changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml > > diff --git a/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml b/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml > new file mode 100644 > index 000000000000..f8536d1a6765 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/beagle,play-cc1352.yaml > @@ -0,0 +1,25 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/beagle,play-cc1352.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: BeaglePlay CC1352 co-processor So this is "Texas Instruments Simplelink CC1352P7 wireless MCU"? Since you do not have any fixed feature and run general-purpose OS, then this should be rather compatible matching actual hardware (so ti,cc1352p7). > + > +maintainers: > + - Ayush Singh <ayushdevel1325@xxxxxxxxx> > + > +properties: > + compatible: > + const: beagle,play-cc1352 > + > +required: > + - compatible Still no resources? I asked about it last time and you did not answer anything. > + > +additionalProperties: false > + > +examples: > + - | > + mcu { > + compatible = "beagle,play-cc1352"; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 37b9626ee654..9d1b49a6dfad 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8969,6 +8969,12 @@ F: drivers/staging/greybus/sdio.c > F: drivers/staging/greybus/spi.c > F: drivers/staging/greybus/spilib.c > > +GREYBUS BEAGLEPLAY DRIVERS > +M: Ayush Singh <ayushdevel1325@xxxxxxxxx> > +L: greybus-dev@xxxxxxxxxxxxxxxx (moderated for non-subscribers) > +S: Maintained > +F: Documentation/devicetree/bindings/serial/beaglecc1352.yaml That's not a correct path. Best regards, Krzysztof