Hi, On 21/09/2023 22:27:43+0200, Linus Walleij wrote: > diff --git a/drivers/rtc/rtc-r7301.c b/drivers/rtc/rtc-r7301.c > index 5dbaeb7af648..843e16966b65 100644 > --- a/drivers/rtc/rtc-r7301.c > +++ b/drivers/rtc/rtc-r7301.c > @@ -14,6 +14,7 @@ > #include <linux/module.h> > #include <linux/mod_devicetable.h> > #include <linux/delay.h> > +#include <linux/property.h> > #include <linux/regmap.h> > #include <linux/platform_device.h> > #include <linux/rtc.h> > @@ -55,12 +56,23 @@ struct rtc7301_priv { > u8 bank; > }; > > -static const struct regmap_config rtc7301_regmap_config = { > +/* > + * When the device is memory-mapped, some platforms pack the registers into > + * 32-bit access using the lower 8 bits at each 4-byte stride, while others > + * expose them as simply consequitive bytes. Shouldn't that be consecutive? -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com