Hey John, On Fri, Sep 22, 2023 at 07:35:19AM +1000, John Watts wrote: > On Thu, Sep 21, 2023 at 11:27:36PM +0200, Uwe Kleine-König wrote: > > Hi John, > > > > On Wed, Sep 06, 2023 at 12:46:19PM +1000, John Watts wrote: > > > On Thu, Aug 24, 2023 at 02:40:24PM +0300, Aleksandr Shubin wrote: > > > > This series adds support for PWM controller on new > > > > Allwinner's SoCs, such as D1, T113s and R329. The implemented driver > > > > provides basic functionality for control PWM channels. > > > > > > I have tested this patch and earlier versions successfully on a Mango Pi MQ > > > Dual and verified it outputs a PWM signal. > > > > If you want that documented, the usual thing to do is to include a > > Tested-by: tag in your reply. > > That's a good idea! I'll take a closer look under a scope and against the data > sheet and give another tested-by then when I can. I'm not sure how close that > gets to a reviewed-by but I don't have the experience in driver development to > know if something is off in the design. Tested-by has little to nothing to do with development or review. If you tested that patch and it worked for you, that's enough to give such a tag. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
