Hi Andrew, On 20/09/23 7:07 pm, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> Ah ok, I think there is a misunderstanding here. This is related to OPEN >> Alliance protocol. Control transactions consist of one or more control >> commands. Control commands are used by the SPI host to read and write >> registers within the MAC-PHY. Each control commands are composed of a >> 32-bit control command header followed by register data. WNR (write not >> read) bit in the control command header indicates if data is to be >> written to registers (when set) or read from registers (when clear). so >> basically it indicates the type of the control command on the registers. > > OK, so this clearly indicates the names are bad and documentation is > missing if i got this completely wrong. Adding kerneldoc to these > functions should help. Sure, I will do that. > > Andrew > >
