On Wed, 20 Sep 2023 18:13:10 -0500 Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, 20 Sep 2023 11:20:15 -0400, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > Convert binding from text format to YAML. > > > > Additions to original text binding: > > - add rs485 reference. > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > --- > > .../bindings/serial/nxp,sc16is7xx.txt | 118 ---------------- > > .../bindings/serial/nxp,sc16is7xx.yaml | 126 ++++++++++++++++++ > > 2 files changed, 126 insertions(+), 118 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > create mode 100644 Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.example.dts:27.13-26: Warning (reg_format): /example-0/serial@51:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.example.dts:37.13-26: Warning (reg_format): /example-0/serial@53:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.example.dts:48.13-26: Warning (reg_format): /example-0/serial@54:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Hi Rob, will fix it for V2. I was already using 'make DT_CHECKER_FLAGS=-m dt_binding_check', but I incorrectly introduced a space between DT_SCHEMA_FILES= and the filename, and so it was ignored and all schemas were checked, and I lost the warnings in all the noise. I now have fixed it. Also, if someone is interested, I was trying to specify multiple files with DT_SCHEMA_FILES, and I just found out (after analysing the Makefile) that you need to separate them with the ":" character. It would be a good thing to add it to the documentation, I could submit a patch for this if you like. Thank you, Hugo. > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230920152015.1376838-5-hugo@xxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > >
