Re: [PATCH 3/6] arm64: xilinx: Remove mt25qu512a compatible string from SOM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On 9/18/23 17:01, Laurent Pinchart wrote:
Hi Michal,

Thank you for the patch.

On Mon, Sep 18, 2023 at 02:41:14PM +0200, Michal Simek wrote:
mt25qu512a is not documented in DT binding that's why remove it.

How about adding the compatible string to the bindings instead ?

Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
---

  arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
index 157dcb4a27a8..cd5cd7f3b5ce 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
@@ -131,7 +131,7 @@ mux {
  &qspi { /* MIO 0-5 - U143 */
  	status = "okay";
  	spi_flash: flash@0 { /* MT25QU512A */
-		compatible = "mt25qu512a", "jedec,spi-nor"; /* 64MB */
+		compatible = "jedec,spi-nor"; /* 64MB */
  		#address-cells = <1>;
  		#size-cells = <1>;
  		reg = <0>;


arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts is using only jedec,spi-nor

Renesas and our SOM are using it.
arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi:310: compatible = "micron,mt25qu512a", "jedec,spi-nor"; arch/arm64/boot/dts/renesas/rzg2lc-smarc-som.dtsi:239: compatible = "micron,mt25qu512a", "jedec,spi-nor"; arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts:136: compatible = "micron,mt25qu512a", "jedec,spi-nor"; /* 64MB */

Rob/Krzysztof/Conor: What's the recommendation? I see 02g variant listed and micron-st also has 256a/512a variants.

Thanks,
Michal




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux