Re: [PATCH 3/4] net: phy: Add GPIO and DT support to NCN26000

[Andrew Lunn <andrew@xxxxxxx>]

On Mon, Sep 18, 2023 at 11:40:36AM +0100, Vadim Fedorenko wrote:
> > +static int ncn26000_gpio_request(struct gpio_chip *gc, unsigned int offset)
> > +{
> > +	struct ncn26000_priv *priv = gpiochip_get_data(gc);
> > +
> > +	if (offset > 2)
> > +		return -ENODEV;
> > +
> > +	if (priv->gpiomask & (1 << offset))
> 
> it's better to use BIT(offset) here

Hi Vadim

When replying, please trim the email to just the relevant text.

     Thanks
	Andrew