On 18/09/2023 08:49, Sebastian Fricke wrote: > Hey Krzysztof, > > thanks for your review. > > On 17.09.2023 09:56, Krzysztof Kozlowski wrote: >> On 15/09/2023 23:11, Sebastian Fricke wrote: >>> From: Robert Beckett <bob.beckett@xxxxxxxxxxxxx> >>> >>> Add bindings for the wave5 chips&media codec driver >>> >>> Signed-off-by: Robert Beckett <bob.beckett@xxxxxxxxxxxxx> >>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> >>> Signed-off-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx> >> >> So this is v12 and still no tested? > > I have tested it, multiple times actually since V11. (For some reason > that indentation issue slipped by me though ...) > If you mean the tested by tag, the patch was completely unnoticed until > v10 by the community, which was partially because me and the previous > commiters didn't use the right recipients for this patch. So from that > point of view this is more like v2. > >> >> A nit, subject: drop second/last, redundant "yaml devicetree indings". >> The "dt-bindings" prefix is already stating that these are bindings. >> Basically three words bringing zero information. > > Okay so: > `dt-bindings: media: wave5: add devicetree` Still not, because devicetree is duplicating "dt". It's redundant. Instead should be (with correct order of prefixes): media: dt-bindings: wave5: add AzureWaveFooBar XYL ABC10 (whatever company and full product name it is) Best regards, Krzysztof
