Hi Andrew, Sure. Thanks for the suggestion. I hope my previous reply for Alexander's email clarifies the below comment as well. It would be nice if Alexandru Tachici gives us more clarity on their device and driver. Best Regards, Parthiban V On 15/09/23 7:52 pm, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Fri, Sep 15, 2023 at 03:56:59PM +0200, Alexander Dahl wrote: >> Hello, >> >> this is interesting, by chance I just looked at a chip claiming >> similar features today, which already has a driver in kernel: Analog >> Devices ADIN1110. > > Ah, interesting. I had no idea this driver/device is an OA TC6 device. > > So ideally, we want the adin1110.c to also use the new framework, and > remove the duplicate code. Parthiban, please look at the driver and > make sure the APIs are such that Alexandru Tachici can swap his driver > to using it. Having two implementations should help make it clear what > is the same and what is different. > > Andrew >
