On 9/15/2023 4:29 AM, Krzysztof Kozlowski wrote: > On 15/09/2023 13:18, Tengfei Fan wrote: >> >> >> 在 9/15/2023 5:16 PM, Krzysztof Kozlowski 写道: >>> On 15/09/2023 11:12, Tengfei Fan wrote: >>>> >>>> >>>> 在 9/15/2023 3:21 PM, Krzysztof Kozlowski 写道: >>>>> On 15/09/2023 04:15, Tengfei Fan wrote: >>>>>> Add the SM4450 interconnect and pinctrl drivers as built-in for >>>>>> support the Qualcomm SM4450 platform to boot to uart shell. >>>>>> >>>>>> Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx> >>>>>> --- >>>>>> arch/arm64/configs/defconfig | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>>>> index ec59174b14db..e91993de865e 100644 >>>>>> --- a/arch/arm64/configs/defconfig >>>>>> +++ b/arch/arm64/configs/defconfig >>>>>> @@ -598,6 +598,7 @@ CONFIG_PINCTRL_SC8280XP=y >>>>>> CONFIG_PINCTRL_SDM660=y >>>>>> CONFIG_PINCTRL_SDM670=y >>>>>> CONFIG_PINCTRL_SDM845=y >>>>>> +CONFIG_PINCTRL_SM4450=y >>>>>> CONFIG_PINCTRL_SM6115=y >>>>>> CONFIG_PINCTRL_SM6125=y >>>>>> CONFIG_PINCTRL_SM6350=y >>>>>> @@ -1500,6 +1501,7 @@ CONFIG_INTERCONNECT_QCOM_SC7280=y >>>>>> CONFIG_INTERCONNECT_QCOM_SC8180X=y >>>>>> CONFIG_INTERCONNECT_QCOM_SC8280XP=y >>>>>> CONFIG_INTERCONNECT_QCOM_SDM845=y >>>>>> +CONFIG_INTERCONNECT_QCOM_SM4450=y >>>>> >>>>> Why it cannot be =m? >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> >>>> Hi Krzysztof, >>>> Because system haven't capacity of loading ko files at this time on >>>> SM4450 platform, so setting to "Y". >>> >>> Hm? System has this capability. All systems have. What is so different >>> on SM4450 comparing to everything else we have here? >>> >>> No, this should be =m and you need to fix your system. >>> >>> Best regards, >>> Krzysztof >>> >> Hi Krzysztof, >> Find new way which can load ko files on SM4450 platform, still need use >> "Y", because of some other modules have dependence to these two config, >> like scm, smmu module drivers, uart shell console cannot be got if set >> to "m". > > That's what I am asking, which device exactly needs it. > >> >> Also do test for setting these two config to "m" on SM8450 platform, get >> uart shell consle failed if so setting. > > Yeah, this we know, I did this. I am asking about SM4450. Why we have =m requirement when other drivers above are =Y?. Can we confirm w/ Georgi? I am not aware that Interconnect drivers needs to be =m only. CONFIG_INTERCONNECT_QCOM_SC8180X=y CONFIG_INTERCONNECT_QCOM_SC8280XP=y CONFIG_INTERCONNECT_QCOM_SDM845=y -- ---Trilok Soni