Re: [PATCH net-next 10/15] net: ethernet: mtk_wed: introduce WED support for MT7988

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Thu, Sep 14, 2023 at 04:38:15PM +0200, Lorenzo Bianconi wrote:
> > From: Sujuan Chen <sujuan.chen@xxxxxxxxxxxx>
> > 
> > Similar to MT7986 and MT7622, enable Wireless Ethernet Ditpatcher for
[...]
> > -	ring_size = dev->wlan.nbuf & ~(MTK_WED_BUF_PER_PAGE - 1);
> > -	n_pages = ring_size / MTK_WED_BUF_PER_PAGE;
> > +	if (!mtk_wed_is_v3_or_greater(dev->hw)) {
> > +		dev->tx_buf_ring.desc_size = sizeof(struct mtk_wdma_desc);
> 
> Instead of checking the version or using of_device_is_compatible() in 
> other places why don't you define driver match data for all this static 
> data.

ack, I will look into it.

Regards,
Lorenzo

> 
> Rob

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux