On Fri, Sep 15, 2023 at 9:50 AM Conor Dooley <conor@xxxxxxxxxx> wrote: > > Yo, > > On Fri, Sep 15, 2023 at 02:29:24PM +0800, Delphine CC Chiu wrote: > > Add dt-bindings for the MAXIM MAX31790. > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > --- > > Changelog: > > v2 - Add dt-bindings for the MAXIM MAX31790. > > --- > > .../bindings/hwmon/maxim,max31790.yaml | 59 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml > > new file mode 100644 > > index 000000000000..2bd455b36b3f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > + > > +$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Maxim max31790 > > + > > +maintainers: > > + - Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > + > > +description: | > > + The MAX31790 controls the speeds of up to six fans using > > + six independent PWM outputs. The desired fan speeds (or PWM duty cycles) > > + are written through the I2C interface. > > + The outputs drive “4-wire” fans directly, or can be used to modulate > > + the fan’s power terminals using an external pass transistor. > > + > > + Datasheets: > > + https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - maxim,max31790 > > + > > + reg: > > + maxItems: 1 > > + > > + pwm-as-tach: > > I don't see any other users of this in-tree, so you'd need a vendor > prefix. That said, I'm once bitten, twice shy about fan related > properties in hwmon, so I would definitely like Rob to comment on this > whole binding. Please see this[1] and comment on it to ensure it meets your needs. Otherwise, omit any fan related properties for now. Rob [1] https://lore.kernel.org/all/20230830123202.3408318-2-billy_tsai@xxxxxxxxxxxxxx/
