On Fri, Sep 15, 2023 at 08:03:04PM +0530, Gaurav Kohli wrote:
> Fix the apps iommu local address space range as per data sheet.
>
> Fixes: 6a6729f38436 ("arm64: dts: qcom: msm8916: Add IOMMU support")
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Gaurav Kohli <quic_gkohli@xxxxxxxxxxx>
Aside from the minor things Konrad mentioned (v1 -> v2) FWIW:
Reviewed-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
Although I can kind of understand that starting to count at 0 often
feels more intuitive, especially for Linux kernel things. :-)
> ---
> Changes since v0:
> -Update Fixes tag.
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 33fb65d73104..3c934363368c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1813,7 +1813,7 @@
> #size-cells = <1>;
> #iommu-cells = <1>;
> compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
> - ranges = <0 0x01e20000 0x40000>;
> + ranges = <0 0x01e20000 0x20000>;
> reg = <0x01ef0000 0x3000>;
> clocks = <&gcc GCC_SMMU_CFG_CLK>,
> <&gcc GCC_APSS_TCU_CLK>;
> --
> 2.17.1
>
