On 15/09/2023 10:10, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> > > Add device tree bindings for the Cirrus Logic EP93xx SoC. > > Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> > --- > .../bindings/arm/cirrus/cirrus,ep9301.yaml | 38 ++++++++++++ > .../bindings/soc/cirrus/cirrus,ep9301-syscon.yaml | 71 ++++++++++++++++++++++ > 2 files changed, 109 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/cirrus/cirrus,ep9301.yaml b/Documentation/devicetree/bindings/arm/cirrus/cirrus,ep9301.yaml > new file mode 100644 > index 000000000000..97dd8b6aefa9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/cirrus/cirrus,ep9301.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/cirrus/cirrus,ep9301.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP93xx platforms > + > +description: > + The EP93xx SoC is a ARMv4T-based with 200 MHz ARM9 CPU. > + > +maintainers: > + - Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> > + - Nikita Shubin <nikita.shubin@xxxxxxxxxxx> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: The TS-7250 is a compact, full-featured Single Board Computer (SBC) > + based upon the Cirrus EP9302 ARM9 CPU > + items: > + - const: technologic,ts7250 > + - const: cirrus,ep9301 > + > + - description: The Liebherr BK3 is a derivate from ts7250 board > + items: > + - const: liebherr,bk3 > + - const: cirrus,ep9301 > + > + - description: EDB302 is an evaluation board by Cirrus Logic, > + based on a Cirrus Logic EP9302 CPU > + items: > + - const: cirrus,edb9302 > + - const: cirrus,ep9301 > + > +additionalProperties: true > diff --git a/Documentation/devicetree/bindings/soc/cirrus/cirrus,ep9301-syscon.yaml b/Documentation/devicetree/bindings/soc/cirrus/cirrus,ep9301-syscon.yaml > new file mode 100644 > index 000000000000..1692250251d9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/cirrus/cirrus,ep9301-syscon.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/cirrus/cirrus,ep9301-syscon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP93xx Platforms System Controller > + > +maintainers: > + - Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> > + - Nikita Shubin <nikita.shubin@xxxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - cirrus,ep9302-syscon > + - cirrus,ep9307-syscon > + - cirrus,ep9312-syscon > + - cirrus,ep9315-syscon > + - const: cirrus,ep9301-syscon > + - const: syscon > + - const: simple-mfd > + - items: > + - const: cirrus,ep9301-syscon > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + reboot: > + type: object > + $ref: /schemas/power/reset/cirrus,ep9301-reboot.yaml There is no need to have empty node without any resources. There are no benefits of this. Drop entire reboot schema and instantiate your driver from parent device. simple-mfd also goes away. syscon probably as well, unless you export registers for other devices? > + > + clock-controller: > + type: object > + $ref: /schemas/clock/cirrus,ep9301-clk.yaml This could be okay, if it took address. But it doesn't, so again, this can be just part of top node. Unless this is a separate device and you miss here proper reg/addressing? > + > + pinctrl: > + type: object > + $ref: /schemas/pinctrl/cirrus,ep9301-pinctrl.yaml No need, drop entire schema and node, just like with reboot. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + syscon@80930000 { > + compatible = "cirrus,ep9301-syscon", > + "syscon", "simple-mfd"; > + reg = <0x80930000 0x1000>; Best regards, Krzysztof
