On 15/09/2023 10:10, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> > Thank you for your patch. There is something to discuss/improve. > diff --git a/include/dt-bindings/clock/cirrus,ep9301-clk.h b/include/dt-bindings/clock/cirrus,ep9301-clk.h > new file mode 100644 > index 000000000000..3cd053c0fdea > --- /dev/null > +++ b/include/dt-bindings/clock/cirrus,ep9301-clk.h > @@ -0,0 +1,41 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > +#ifndef DT_BINDINGS_CIRRUS_EP93XX_CLOCK_H > +#define DT_BINDINGS_CIRRUS_EP93XX_CLOCK_H > + > +#define EP93XX_CLK_UART1 0 > +#define EP93XX_CLK_UART2 1 > +#define EP93XX_CLK_UART3 2 > + > +#define EP93XX_CLK_ADC 3 > +#define EP93XX_CLK_ADC_EN 4 > + > +#define EP93XX_CLK_KEYPAD 5 Wrong indentation - use tab instead of spaces, just like in other places. > + > +#define EP93XX_CLK_VIDEO 6 > + > +#define EP93XX_CLK_I2S_MCLK 7 > +#define EP93XX_CLK_I2S_SCLK 8 > +#define EP93XX_CLK_I2S_LRCLK 9 > + > +#define EP93XX_CLK_UART 10 > +#define EP93XX_CLK_SPI 11 > +#define EP93XX_CLK_PWM 12 > +#define EP93XX_CLK_USB 13 > + > +#define EP93XX_CLK_M2M0 14 > +#define EP93XX_CLK_M2M1 15 > + > +#define EP93XX_CLK_M2P0 16 > +#define EP93XX_CLK_M2P1 17 > +#define EP93XX_CLK_M2P2 18 > +#define EP93XX_CLK_M2P3 19 > +#define EP93XX_CLK_M2P4 20 > +#define EP93XX_CLK_M2P5 21 > +#define EP93XX_CLK_M2P6 22 > +#define EP93XX_CLK_M2P7 23 > +#define EP93XX_CLK_M2P8 24 > +#define EP93XX_CLK_M2P9 25 > + > +#define EP93XX_CLK_END 26 Here as well... except I propose to drop it. Number of clocks should not be part of bindings, because then you cannot grow it. With indentation fixed and CLK_END dropped: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
