On 13/09/2023 15:57, Yang Chen wrote: > Hi Krzysztof, > >> + >> +&i2c15 { >> + status = "okay"; >> + >> + eeprom@50 { >> + compatible = "atmel,24c128"; >> + reg = <0x50>; >> + }; >> +}; >> + >> +&adc0 { >> + ref_voltage = <2500>; > > There is no such property in the bindings. Fix your email setup. This is my response, not yours. > >> + status = "okay"; >> + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default >> + &pinctrl_adc2_default &pinctrl_adc3_default >> + &pinctrl_adc4_default &pinctrl_adc5_default >> + &pinctrl_adc6_default &pinctrl_adc7_default>; >> +}; >> + >> +&adc1 { >> + ref_voltage = <2500>; > > NAK, there is no such property. > So who says what? > Thanks for your advice, I will change this property to > "aspeed,int-vref-microvolt" which is defined in the binding in the v2 patch. No, why? Drop it. There is no user. Also, do not top post. Best regards, Krzysztof