On Fri, 08 Sep 2023 10:31:35 +0100, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Marc, > > On Thu, Aug 11, 2022 at 4:50 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Sun, Jul 24, 2022 at 1:01 PM Marc Zyngier <maz@xxxxxxxxxx> wrote: > > > On Fri, 22 Jul 2022 16:11:54 +0100, > > > Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > > > > > > > > Update description for '#interrupt-cells' property to utilize the > > > > RZG2L_{NMI,IRQX} for the first cell defined in the > > > > include/dt-bindings/interrupt-controller/irqc-rzg2l.h file. > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > --- > > > > v3: > > > > * New patch > > > > > > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > > > > @@ -31,8 +31,9 @@ properties: > > > > - const: renesas,rzg2l-irqc > > > > > > > > '#interrupt-cells': > > > > - description: The first cell should contain external interrupt number (IRQ0-7) and the > > > > - second cell is used to specify the flag. > > > > + description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the > > > > + include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second > > > > + cell is used to specify the flag. > > > > > > I think a binding should be self describing, and not rely on an opaque > > > macro. Mentioning that there is a macro that encodes it is fine, but > > > the values are what matter, specially when considering that other OSs > > > could (and should be able to) write their own DTs from scratch without > > > depending on something that is very much Linux-specific. > > > > The macros are not Linux-specific, and are part of the bindings. > > But the only hard dependency on <dt-bindings/interrupt-controller/irqc-rzg2l.h> > > is the DT source file describing the board. > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Looks like this fell through the cracks? > The two other patches from this series were applied in v6.1. > > Note that the current DT bindings are incorrect, as they do not take into > account that the value of zero is used to represent the NMI. > > Fixes: 96fed779d3d4cb3c ("dt-bindings: interrupt-controller: Add > Renesas RZ/G2L Interrupt Controller") > > Should we resend instead? It applied cleanly to v6.6-rc1, so there should be no need. Thanks, M. -- Without deviation from the norm, progress is not possible.