Re: [PATCH 3/9] arm64: dts: qcom: msm8916-ufi: Drop gps_mem for now

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 12, 2023 at 07:36:43AM +0100, Bryan O'Donoghue wrote:
> On 11/09/2023 18:41, Stephan Gerhold wrote:
> > gps_mem is needed by the modem firmware for GPS to work. However, it is
> > accessed via QMI memshare [1] which is not available upstream yet.
> > Until it lands upstream reserving this does not provide any advantage.
> > 
> > [1]: https://lore.kernel.org/linux-arm-msm/20210319172321.22248-1-nikitos.tr@xxxxxxxxx/
> > 
> > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi | 5 -----
> >   1 file changed, 5 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
> > index c759c0544dd9..69f268db4df9 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
> > @@ -22,11 +22,6 @@ mpss_mem: mpss@86800000 {
> >   			reg = <0x0 0x86800000 0x0 0x5500000>;
> >   			no-map;
> >   		};
> > -
> > -		gps_mem: gps@8bd00000 {
> > -			reg = <0x0 0x8bd00000 0x0 0x200000>;
> > -			no-map;
> > -		};
> >   	};
> >   	gpio-keys {
> > 
> 
> Should this have a Fixes tag, should probably be applied to stable.
> 

I'm probably a bit "overcautious" when it comes to stable backporting,
but I think this is not strictly a fix but more like cleanup. It doesn't
cause any trouble to reserve the extra memory, it just wastes some RAM.

Thanks,
Stephan



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux