Re: [PATCH v2 1/3] dt-bindings: power: rpmpd: Add MSM8917, MSM8937 and QM215

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/09/2023 07:00, Otto Pflüger wrote:
> The MSM8917, MSM8937 and QM215 SoCs have VDDCX and VDDMX power domains
> controlled in voltage level mode. Define the MSM8937 and QM215 power
> domains as aliases because these SoCs are similar to MSM8917 and may
> share some parts of the device tree.
> 
> Also add the compatibles for these SoCs to the documentation, with
> qcom,msm8937-rpmpd using qcom,msm8917-rpmpd as a fallback compatible
> because there are no known differences. QM215 is not compatible with
> these because it uses different regulators.
> 
> Signed-off-by: Otto Pflüger <otto.pflueger@xxxxxxxxx>
> ---
>  .../devicetree/bindings/power/qcom,rpmpd.yaml | 79 ++++++++++---------
>  include/dt-bindings/power/qcom-rpmpd.h        | 21 +++++
>  2 files changed, 64 insertions(+), 36 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> index 9b03c41d3604..d4dac8b54045 100644
> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -15,42 +15,49 @@ description:
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,mdm9607-rpmpd
> -      - qcom,msm8226-rpmpd
> -      - qcom,msm8909-rpmpd
> -      - qcom,msm8916-rpmpd
> -      - qcom,msm8939-rpmpd
> -      - qcom,msm8953-rpmpd
> -      - qcom,msm8976-rpmpd
> -      - qcom,msm8994-rpmpd
> -      - qcom,msm8996-rpmpd
> -      - qcom,msm8998-rpmpd
> -      - qcom,qcm2290-rpmpd
> -      - qcom,qcs404-rpmpd
> -      - qcom,qdu1000-rpmhpd
> -      - qcom,sa8155p-rpmhpd
> -      - qcom,sa8540p-rpmhpd
> -      - qcom,sa8775p-rpmhpd
> -      - qcom,sdm660-rpmpd
> -      - qcom,sc7180-rpmhpd
> -      - qcom,sc7280-rpmhpd
> -      - qcom,sc8180x-rpmhpd
> -      - qcom,sc8280xp-rpmhpd
> -      - qcom,sdm670-rpmhpd
> -      - qcom,sdm845-rpmhpd
> -      - qcom,sdx55-rpmhpd
> -      - qcom,sdx65-rpmhpd
> -      - qcom,sdx75-rpmhpd
> -      - qcom,sm6115-rpmpd
> -      - qcom,sm6125-rpmpd
> -      - qcom,sm6350-rpmhpd
> -      - qcom,sm6375-rpmpd
> -      - qcom,sm8150-rpmhpd
> -      - qcom,sm8250-rpmhpd
> -      - qcom,sm8350-rpmhpd
> -      - qcom,sm8450-rpmhpd
> -      - qcom,sm8550-rpmhpd
> +    oneOf:
> +      - enum:
> +          - qcom,mdm9607-rpmpd
> +          - qcom,msm8226-rpmpd
> +          - qcom,msm8909-rpmpd
> +          - qcom,msm8916-rpmpd
> +          - qcom,msm8917-rpmpd
> +          - qcom,msm8939-rpmpd
> +          - qcom,msm8953-rpmpd
> +          - qcom,msm8976-rpmpd
> +          - qcom,msm8994-rpmpd
> +          - qcom,msm8996-rpmpd
> +          - qcom,msm8998-rpmpd
> +          - qcom,qcm2290-rpmpd
> +          - qcom,qcs404-rpmpd
> +          - qcom,qdu1000-rpmhpd
> +          - qcom,qm215-rpmpd
> +          - qcom,sa8155p-rpmhpd
> +          - qcom,sa8540p-rpmhpd
> +          - qcom,sa8775p-rpmhpd
> +          - qcom,sdm660-rpmpd

Move it down to sort, while you are changing it.


With above (and assumption if you ever need to rebase the patch you will
be extra careful and re-check all entries):

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux