On 12/09/2023 08:29, Macpaul Lin wrote: > >>> Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/arm/mediatek.yaml | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> change for v2: >>> - rebase this patch to follow the v5 patch set of mt8395. >>> - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@xxxxxxxxxxxx/T/ >>> - Fix description as a single board. >>> >>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml >>> index 2e8ad49c3479..b163995e32d5 100644 >>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml >>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml >>> @@ -244,7 +244,8 @@ properties: >>> - enum: >>> - mediatek,mt8183-pumpkin >>> - const: mediatek,mt8183 >>> - - items: >>> + - description: MediaTek Genio 350 Board (Genio 350 EVK) >> >> Drop, no need, redundant (copies the compatible) and your other entries >> do not have it. > > The primary objective of this patch is to incorporate a description that > will prevent users from confusing this platform with others. How platform can be confused? The compatibles define it, not description. > Additionally, it aids in identifying this as a "Genio EVK" for marketing > purposes. Kernel is not a place for marketing. > Thanks > Macpaul Lin Best regards, Krzysztof