On 11/09/2023 11:49, John Watts wrote: > Hello again, > > On Mon, Sep 11, 2023 at 11:41:12AM +0200, Krzysztof Kozlowski wrote: >>> +maintainers: >>> + - John Watts <contact@xxxxxxxxxx> >>> + >>> +allOf: >>> + - $ref: panel-common.yaml# >>> + - $ref: /schemas/spi/spi-peripheral-props.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: fascontek,fs035vg158 >>> + >>> + backlight: true >>> + port: true >>> + power-supply: true >>> + reg: true >>> + reset-gpios: true >> >> Why do you need all these 5? They are allowed by panel-common. >> >>> + >>> + spi-3wire: true >>> + >>> +required: >>> + - compatible >> >> Missing reg. Probably also port. >> >> >>> + - power-supply >>> + - reset-gpios >>> + > > I have just copy pasted the other panel's yaml, so these issues apply > there too. Should I fix that panel's yaml up first then re-copy? If the other panel has exactly the same case, then yes, you can do like this. But it depends on the bindings - to which ones do you refer as your tmeplate? Best regards, Krzysztof
