On 11.09.2023 15:16, Otto Pflüger wrote:
> MSM8917 uses the SMPA2 and LDOA3 regulators provided by the PM8937 PMIC
> for the VDDCX and VDDMX power domains in voltage level mode,
> respectively. MSM8937 also uses this PMIC and the same regulators.
>
> QM215 is typically paired with a PM8916 PMIC and uses its SMPA1 and
> LDOA2 regulators in voltage level mode.
>
> Signed-off-by: Otto Pflüger <otto.pflueger@xxxxxxxxx>
> ---
Generally one-per-commit is the consensus.
> +
> static struct rpmpd *sdm660_rpmpds[] = {
> [SDM660_VDDCX] = &cx_rwcx0_lvl,
> [SDM660_VDDCX_AO] = &cx_rwcx0_lvl_ao,
> @@ -764,6 +853,8 @@ static const struct of_device_id rpmpd_match_table[] = {
> { .compatible = "qcom,msm8226-rpmpd", .data = &msm8226_desc },
> { .compatible = "qcom,msm8909-rpmpd", .data = &msm8916_desc },
> { .compatible = "qcom,msm8916-rpmpd", .data = &msm8916_desc },
> + { .compatible = "qcom,msm8917-rpmpd", .data = &msm8917_desc },
> + { .compatible = "qcom,msm8937-rpmpd", .data = &msm8917_desc },
Don't add two compatibles pointing to the same thing, or you'll
get an angry response from Krzysztof :D
You can do:
compatible = "qcom,msm8937-rpmpd", "qcom,msm8917-rpmpd";
and document the fallback in bindings
Konrad
