On Fri, Sep 1, 2023 at 2:27 AM Frank Wunderlich <linux@xxxxxxxxx> wrote: > > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > > Bananapi R3 has a Power socket entended for using external SATA drives. > This Socket is off by default but can be switched with gpio 8. > > Add an overlay to activate it. > > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../mt7986a-bananapi-bpi-r3-sata.dtso | 39 +++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sata.dtso > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index c99c3372a4b5..822d3e36d3df 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo > dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sata.dtbo The requirement for overlays is they have a target base dt in tree and that you apply the overlay to it. All these existing overlays have the same problem which I pointed out when you submitted them. Please fix the existing ones before adding more. Rob
