On 11/09/2023 11:02, John Watts wrote: > This is a small 3.5" 640x480 IPS LCD panel. > > Signed-off-by: John Watts <contact@xxxxxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. > +maintainers: > + - John Watts <contact@xxxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + const: fascontek,fs035vg158 > + > + backlight: true > + port: true > + power-supply: true > + reg: true > + reset-gpios: true Why do you need all these 5? They are allowed by panel-common. > + > + spi-3wire: true > + > +required: > + - compatible Missing reg. Probably also port. > + - power-supply > + - reset-gpios > + Best regards, Krzysztof
