On 10/09/2023 13:00:27+0200, Javier Carrasco wrote: > Convert the existing txt binding to the preferred YAML format. > > The pcf2123 node may contain SPI settings such as spi-cs-high and > spi-max-frequency, which keeps it from being added to the trivial-rtc > binding with its current definition. Add a reference to > spi-peripheral-props.yaml to account for that. > > The "interrupts" property was missing in the binding although it is > already supported. Add the missing property in the new binding. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> > --- > .../devicetree/bindings/rtc/nxp,pcf2123.yaml | 45 ++++++++++++++++++++++ > .../devicetree/bindings/rtc/nxp,rtc-2123.txt | 17 -------- > 2 files changed, 45 insertions(+), 17 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2123.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2123.yaml > new file mode 100644 > index 000000000000..013e5e5dc0ae > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2123.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/nxp,pcf2123.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP PCF2123 SPI Real Time Clock > + > +maintainers: > + - Chris Verges <chrisv@xxxxxxxxxxxxxxxxxx> Is Chris willing to maintain the binding? > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + enum: > + - nxp,pcf2123 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@3 { > + compatible = "nxp,pcf2123"; > + reg = <3>; > + spi-cs-high; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/rtc/nxp,rtc-2123.txt b/Documentation/devicetree/bindings/rtc/nxp,rtc-2123.txt > deleted file mode 100644 > index 7371f525a687..000000000000 > --- a/Documentation/devicetree/bindings/rtc/nxp,rtc-2123.txt > +++ /dev/null > @@ -1,17 +0,0 @@ > -NXP PCF2123 SPI Real Time Clock > - > -Required properties: > -- compatible: should be: "nxp,pcf2123" > - or "microcrystal,rv2123" > -- reg: should be the SPI slave chipselect address > - > -Optional properties: > -- spi-cs-high: PCF2123 needs chipselect high > - > -Example: > - > -pcf2123: rtc@3 { > - compatible = "nxp,pcf2123" > - reg = <3> > - spi-cs-high; > -}; > > --- > base-commit: 535a265d7f0dd50d8c3a4f8b4f3a452d56bd160f > change-id: 20230907-topic-pcf2123_yaml-2ce57f4e77d7 > > Best regards, > -- > Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
