On Tue, Dec 09, 2014 at 08:21:30PM +0000, Lee Jones wrote:
> This patch adds support for the SPI portion of ST's SSC device.
I've applied both of these, though I had to rename the DT binding
document and...
> +static int spi_st_clk_enable(struct spi_st *spi_st)
> +{
> + /*
> + * Current platforms use one of the core clocks for SPI and I2C.
> + * If we attempt to disable the clock, the system will hang.
> + *
> + * TODO: Remove this when platform supports power domains.
> + */
> + return 0;
> +
> + return clk_prepare_enable(spi_st->clk);
> +}
...this is not good at all and a step back from the previous version -
if there are problems with the SoC integration they need to be fixed
there or possibly in the clock driver for the SoC rather than bodging
individual drivers.
Attachment:
signature.asc
Description: Digital signature
