On Fri, Sep 08, 2023 at 03:52:22PM -0500, Rob Herring wrote: > On Wed, Sep 06, 2023 at 08:31:18AM +0900, Paul Elder wrote: > > Add overlays for the Pumpkin i350 to support THP7312 cameras. > > > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/mediatek/Makefile | 4 + > > .../mt8365-pumpkin-common-thp7312.dtsi | 23 ++++++ > > .../mt8365-pumpkin-csi0-thp7312-imx258.dtso | 73 +++++++++++++++++++ > > .../mt8365-pumpkin-csi1-thp7312-imx258.dtso | 73 +++++++++++++++++++ > > 4 files changed, 173 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi1-thp7312-imx258.dtso > > > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > > index 20570bc40de8..ceaf24105001 100644 > > --- a/arch/arm64/boot/dts/mediatek/Makefile > > +++ b/arch/arm64/boot/dts/mediatek/Makefile > > @@ -56,4 +56,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > > > > +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi0-thp7312-imx258.dtbo > > +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi1-thp7312-imx258.dtbo > > mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo > > This has no effect. You are assigning the same variable 3 times. It > needs to be every overlay applied to its base is a *-dtbs variable and > then those are all added to 'dtb-y'. IOW, we don't allow overlays which > can't be applied at build time. > > Assuming the overlays aren't mutually exclusive, you could do: > > mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo > mtk-mt8365-pumpkin-dtbs += mt8365-pumpkin-csi0-thp7312-imx258.dtbo > mtk-mt8365-pumpkin-dtbs += mt8365-pumpkin-csi1-thp7312-imx258.dtbo > > This works the same way as '-objs' variables to group .o files into a > module. > > > + > > +dtb-$(CONFIG_ARCH_MEDIATEK) += mtk-mt8365-pumpkin.dtb > > Looks like mtk-mt8365-pumpkin.dtb failed to get built before. In any > case, that's a terrible name. What's the difference between > mt8365-pumpkin.dtb and mtk-mt8365-pumpkin.dtb? There's no clue. That's a bad name indeed. The cover letter indicates that this patch depends on currently out-of-tree DT changes, including a work-in-progress commit that adds mt8365-pumpkin-ethernet-usb.dtbo. The commits order makes this patch look weird. Paul, in your v2, please indicate in the commit message of this patch that it isn't intended to be merged yet. A "[DNI]" prefix in the subject line will help. -- Regards, Laurent Pinchart
