On 7.09.2023 21:54, Anjelique Melendez wrote: > > > On 8/30/2023 11:34 AM, Konrad Dybcio wrote: >> On 30.08.2023 20:06, Anjelique Melendez wrote: >>> Update the pmi632 lpg_data struct so that pmi632 devices use PPG >>> for LUT pattern. >>> >>> Signed-off-by: Anjelique Melendez <quic_amelende@xxxxxxxxxxx> >>> --- >>> drivers/leds/rgb/leds-qcom-lpg.c | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c >>> index 90dc27d5eb7c..0b37d3b539f8 100644 >>> --- a/drivers/leds/rgb/leds-qcom-lpg.c >>> +++ b/drivers/leds/rgb/leds-qcom-lpg.c >>> @@ -1672,11 +1672,14 @@ static const struct lpg_data pm8994_lpg_data = { >>> static const struct lpg_data pmi632_lpg_data = { >>> .triled_base = 0xd000, >>> >>> + .lut_size = 64, >>> + .lut_sdam_base = 0x80, >> Is that a predefined space for use with LPG? >> >> Or can it be reclaimed for something else? >> >> Konrad > Yes, this is a predefined space for use with LPG We represent the SDAM as a NVMEM device, generally it would be nice to add all regions within it as subnodes in the devicetree. Krzysztof, opinions? Konrad