On 06/09/2023 18:22, Stefan x Nilsson wrote: > Add bindings for a driver for Sitronix st7735s display controller, as > well as for a Winstar wf0096atyaa3dnn0 0.96" 80x160 TFT panel. Commit msg and subject: if by "driver" you mean Linux driver, then drop these references and focus on the hardware. > > Signed-off-by: Stefan x Nilsson <stefan.x.nilsson@xxxxxxxx> > --- > .../bindings/display/sitronix,st7735s.yaml | 81 ++++++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 87 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735s.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735s.yaml > new file mode 100644 > index 000000000000..36234ec22fe2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735s.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sitronix,st7735s.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sitronix ST7735S Display Panels > + > +maintainers: > + - Stefan x Nilsson <stefan.x.nilsson@xxxxxxxx> > + > +description: > + This binding is for display panels using a Sitronix ST7735S > + controller in SPI mode. Drop: "This binding is for". Describe the hardware instead. > + > +allOf: > + - $ref: panel/panel-common.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + oneOf: You do not have multiple choices here, so why oneOf? Do you expect it to grow very soon? > + - description: > + Winstar WF0096ATYAA3DNN0 0.96" 80x160 Color TFT > + items: > + - enum: > + - winstar,wf0096atyaa3dnn0 > + - const: sitronix,st7735s > + > + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX) > + > + backlight: true > + reg: true > + spi-max-frequency: true > + reset-gpios: true > + rotation: true > + > +required: > + - compatible > + - reg > + - dc-gpios > + > +additionalProperties: true This cannot be true. From where did you get such code as example? > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&gpio 44 GPIO_ACTIVE_HIGH>; > + }; Drop node, not related. > + > + regdisplay: regulatordisplay { > + compatible = "regulator-fixed"; > + regulator-name = "display"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-enable-ramp-delay = <100000>; > + enable-active-high; Drop node, not related. Again: from where did you get such example? > + }; > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0 { > + compatible = "winstar,wf0096atyaa3dnn0","sitronix,st7735s"; You need to fix formatting. Missing space after ,. Wrong indentation. Use 4 spaces for example indentation. > + reg = <0>; > + spi-max-frequency = <12000000>; > + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio 23 GPIO_ACTIVE_HIGH>; > + backlight = <&backlight>; > + power-supply = <®dsiplay>; > + rotation = <270>; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 6308efa121e1..c00b2b9086f2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6728,6 +6728,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > F: drivers/gpu/drm/tiny/st7735r.c > > +DRM DRIVER FOR SITRONIX ST7735S PANELS > +M: Stefan x Nilsson <stefan.x.nilsson@xxxxxxxx> > +S: Maintained > +T: git git://anongit.freedesktop.org/drm/drm-misc Do you have the push rights to this repo? If not, then don't add it. Best regards, Krzysztof
